RE: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

["Liang, Prike" <Prike.Liang@xxxxxxx>]

Thanks review .

 

Initial thoughts use this patch for overall initializing the UMD_PSATET_* assignment and

some Pstate definitions are not used for patch#2. But combine those two patches also seems well.

 

Thanks,

Prike

From: Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>
Sent: Wednesday, September 4, 2019 2:32 PM
To: Liang, Prike <Prike.Liang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: Re: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

 

i think it's better to merge these two patches into one patch.

after fixed: Reviewed-by: Kevin Wang <kevin1.wang@xxxxxxx>

 

Best Regards,
Kevin

---

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Liang, Prike <Prike.Liang@xxxxxxx>
Sent: Wednesday, September 4, 2019 2:01 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang, Prike <Prike.Liang@xxxxxxx>
Subject: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

 

Add UMD PState macro definition for PState update.

Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx>
reviewed-by: Evan Quan <evan.quan@xxxxxxx>

[Kevin]: change "reviewed-by" to "Reviewed-by"

---
 drivers/gpu/drm/amd/powerplay/renoir_ppt.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h
index e9b7237..a017a47 100644
--- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h
+++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h
@@ -25,4 +25,9 @@
 
 extern void renoir_set_ppt_funcs(struct smu_context *smu);
 
+//UMD PState Renoir Msg Parameters in MHz
+#define RENOIR_UMD_PSTATE_GFXCLK       700
+#define RENOIR_UMD_PSTATE_SOCCLK       678
+#define RENOIR_UMD_PSTATE_FCLK         800
+
 #endif
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx