Re: [PATCH] drm/amdgpu/irq: check if nbio funcs exist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

Sent from my iPhone

> On Sep 1, 2019, at 13:39, Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
> 
> We need to check if the nbios funcs exist before
> checking the individual pointers.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 3e49aa1465e2..0782f9153b60 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -156,10 +156,12 @@ irqreturn_t amdgpu_irq_handler(int irq, void *arg)
>     * register to check whether the interrupt is triggered or not, and properly
>     * ack the interrupt if it is there
>     */
> -    if (adev->nbio.funcs->handle_ras_controller_intr_no_bifring)
> +    if (adev->nbio.funcs &&
> +        adev->nbio.funcs->handle_ras_controller_intr_no_bifring)
>        adev->nbio.funcs->handle_ras_controller_intr_no_bifring(adev);
> 
> -    if (adev->nbio.funcs->handle_ras_err_event_athub_intr_no_bifring)
> +    if (adev->nbio.funcs &&
> +        adev->nbio.funcs->handle_ras_err_event_athub_intr_no_bifring)
>        adev->nbio.funcs->handle_ras_err_event_athub_intr_no_bifring(adev);
> 
>    return ret;
> -- 
> 2.20.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux