On 2019-08-29 10:08 a.m., Grodzovsky, Andrey wrote: > > Agree, the placement of amdgpu_amdkfd_pre/post _reset in > amdgpu_device_lock/unlock_adev is a bit wierd. > amdgpu_device_reset_sriov already calls amdgpu_amdkfd_pre/post_reset itself while it has exclusive access to the GPU. It would make sense to move the same calls into amdgpu_do_asic_reset for the bare-metal case. Regards, Felix > Andrey > > On 8/29/19 10:06 AM, Koenig, Christian wrote: >>> Felix advised that the way to stop all KFD activity is simply to NOT >>> call amdgpu_amdkfd_post_reset so that why I added this. Do you mean you >>> prefer amdgpu_amdkfd_post_reset to be outside of amdgpu_device_unlock_adev ? >> Yes, exactly. It doesn't seems to be related to the unlock operation in >> the first place, but rather only signals the KFD that the reset is >> completed. >> >> Christian. >> > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
