Re: libdrm patch merge request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This broke the CI pipeline:
https://gitlab.freedesktop.org/mesa/drm/pipelines/54903

Looks like the problem is that the autotools build doesn't properly
disable the amdgpu tests when the json-c library is missing. I suggest
the following:

1. Add a HAVE_JSONC guard in tests/Makefile.am
2. Add libjson-c-dev to the packages installed by the oldest-autotools
   job in .gitlab-ci.yml


Until libdrm uses GitLab merge requests to catch this kind of issue
before it hits master, please push changes to a branch in a forked
personal repository and make sure the CI pipeline comes back green
before asking for them to be pushed to master.


Thanks,


On 2019-08-09 3:25 a.m., Chen, Guchun wrote:
> Thanks, Alex.
> 
> Regards,
> Guchun
> 
> -----Original Message-----
> From: Alex Deucher <alexdeucher@xxxxxxxxx> 
> Sent: Friday, August 9, 2019 1:24 AM
> To: Chen, Guchun <Guchun.Chen@xxxxxxx>
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Li, Candice <Candice.Li@xxxxxxx>; Li, Dennis <Dennis.Li@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
> Subject: Re: libdrm patch merge request
> 
> Done!
> 
> Alex
> 
> On Thu, Aug 8, 2019 at 5:18 AM Chen, Guchun <Guchun.Chen@xxxxxxx> wrote:
>>
>> Hi Alex,
>>
>>
>>
>> Would you mind merging attached 3 patches to libdrm master branch?
>>
>> These changes are implemented for gfx and umc ras inject unit test by amdgpu_test.
>>
>> Thanks a lot.
>>
>>
>>
>> Regards,
>>
>> Guchun
>>
>>
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux