Re: [PATCH] drm/amdgpu: Fix GPU reset crash regression.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 2, 2019 at 4:53 PM Andrey Grodzovsky
<andrey.grodzovsky@xxxxxxx> wrote:
>
> amdgpu_ip_block.status.hw for GMC wasn't set to
> false on suspend during GPU reset and so on resume gmc_v9_0_resume
> wasn't called.
> Caused by 'drm/amdgpu: fix double ucode load by PSP(v3)'
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 31abd88..67a1f54 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2270,9 +2270,10 @@ static int amdgpu_device_ip_suspend_phase2(struct amdgpu_device *adev)
>                                                   adev->mp1_state, r);
>                                         return r;
>                                 }
> -                               adev->ip_blocks[i].status.hw = false;
>                         }
>                 }
> +
> +               adev->ip_blocks[i].status.hw = false;
>         }
>
>         return 0;
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux