Applied. Thanks! Alex On Wed, Jul 31, 2019 at 11:17 PM Quan, Evan <Evan.Quan@xxxxxxx> wrote: > > Thanks Matt. The patch is reviewed-by: Evan Quan <evan.quan@xxxxxxx> > > Regards, > Evan > > -----Original Message----- > > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > > Matt Coffin > > Sent: Thursday, August 01, 2019 4:15 AM > > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Matt Coffin <mcoffin13@xxxxxxxxx> > > Subject: [PATCH] drm/amd/powerplay: Allow changing of fan_control in > > smu_v11_0 > > > > [Why] > > Before this change, the fan control state on smu_v11 was not able to be > > changed because the capability check for checking if the fan control capability > > existed was inverted. > > > > [How] > > The capability check for fan control in smu_v11_0_auto_fan_control was > > inverted, to correctly check for the absence, instead of presence of fan > > control capabilities. > > > > Signed-off-by: Matt Coffin <mcoffin13@xxxxxxxxx> > > --- > > drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c > > b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c > > index 0588dd8cd1ba..43fcbdbba630 100644 > > --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c > > +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c > > @@ -1361,7 +1361,7 @@ smu_v11_0_auto_fan_control(struct smu_context > > *smu, bool auto_fan_control) { > > int ret = 0; > > > > - if (smu_feature_is_supported(smu, > > SMU_FEATURE_FAN_CONTROL_BIT)) > > + if (!smu_feature_is_supported(smu, > > SMU_FEATURE_FAN_CONTROL_BIT)) > > return 0; > > > > ret = smu_feature_set_enabled(smu, > > SMU_FEATURE_FAN_CONTROL_BIT, auto_fan_control); > > -- > > 2.22.0 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx