EccErrInt field of EccErrCntSel specifies the type of interrupt, it's not threshold. But my comment for the code is not proper, I'll update the comment. > -----Original Message----- > From: Zhang, Hawking <Hawking.Zhang@xxxxxxx> > Sent: 2019年8月1日 15:52 > To: Zhou1, Tao <Tao.Zhou1@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Li, > Dennis <Dennis.Li@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx>; > Pan, Xinhui <Xinhui.Pan@xxxxxxx> > Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx> > Subject: RE: [PATCH 0/4] enable umc ras ce interrupt > > 1.) Please fix the typo in patch #2 description: ec --> ce 2). Patch #2 > > + ecc_err_cnt_sel = REG_SET_FIELD(ecc_err_cnt_sel, > UMCCH0_0_EccErrCntSel, > + EccErrInt, 0x1); > For the EccErrInt field, it should be programed to be (MAX - INIT), correct? > but the hardcoded value seems not match with the value calculated by those > macro. > > Regards, > Hawking > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Tao > Zhou > Sent: 2019年8月1日 14:54 > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking > <Hawking.Zhang@xxxxxxx>; Li, Dennis <Dennis.Li@xxxxxxx>; Chen, > Guchun <Guchun.Chen@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx> > Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx> > Subject: [PATCH 0/4] enable umc ras ce interrupt > > These patches add support for umc ce interrupt, the interrupt is controlled > by a error count threshold. > > Tao Zhou (4): > drm/amdgpu: support ce interrupt in ras module > drm/amdgpu: implement umc ras init function > drm/amdgpu: update the calc algorithm of umc ecc error count > drm/amdgpu: only uncorrectable error needs gpu reset > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 12 ++++--- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +++- > drivers/gpu/drm/amd/amdgpu/umc_v6_1.c | 42 > ++++++++++++++++++++++--- > drivers/gpu/drm/amd/amdgpu/umc_v6_1.h | 7 +++++ > 4 files changed, 58 insertions(+), 9 deletions(-) > > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
