Re: [PATCH 2/2] drm/amdkfd: enable KFD support for navi14

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-07-31 12:33 a.m., Yuan, Xiaojie wrote:
> Reviewed-by: Xiaojie Yuan <xiaojie.yuan@xxxxxxx>
>
> BR,
> Xiaojie
>
> ________________________________________
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Alex Deucher <alexdeucher@xxxxxxxxx>
> Sent: Saturday, July 27, 2019 3:16 AM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander
> Subject: [PATCH 2/2] drm/amdkfd: enable KFD support for navi14
>
> Same as navi10.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Sorry, I just got back from vacation. This patch is Reviewed-by: Felix 
Kuehling <Felix.Kuehling@xxxxxxx>

But for this to do anything useful, we'll also need to add the Navi14 
device IDs and some ASIC info to KFD. Otherwise you'll probably hit this 
dev_warn in kfd_device.c: lookup_device_info:

         dev_warn(kfd_device, "DID %04x is missing in supported_devices\n",
                  did);

Regards,
   Felix


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index f052c70e4659..97f7c5235cc9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -91,6 +91,7 @@ void amdgpu_amdkfd_device_probe(struct amdgpu_device *adev)
>                  kfd2kgd = amdgpu_amdkfd_arcturus_get_functions();
>                  break;
>          case CHIP_NAVI10:
> +       case CHIP_NAVI14:
>                  kfd2kgd = amdgpu_amdkfd_gfx_10_0_get_functions();
>                  break;
>          default:
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux