Just some cosmetic notes on this one:
On 2019-07-24 4:10 p.m., Andrey Grodzovsky wrote:
> HW requires for caching to be unset for scanout BO
> mappings when the BO placement is in GTT memory.
> Usually the flag to unset is passed from user mode
> but for FB mode this was missing.
>
> v2:
> Move all BO placemnt logic to amdgpu_display_supported_domains
Spelling: "placemnt" => "placement"
This note is a bit confusing, since this patch doesn't move anything
into amdgpu_display_supported_domains. How about e.g. "Keep all BO
placement logic in amdgpu_display_supported_domains"?
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> index e476092..bf0c61b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -137,14 +137,14 @@ static int amdgpufb_create_pinned_object(struct amdgpu_fbdev *rfbdev,
> mode_cmd->pitches[0] = amdgpu_align_pitch(adev, mode_cmd->width, cpp,
> fb_tiled);
> domain = amdgpu_display_supported_domains(adev);
> -
> height = ALIGN(mode_cmd->height, 8);
> [...]
> @@ -166,7 +166,6 @@ static int amdgpufb_create_pinned_object(struct amdgpu_fbdev *rfbdev,
> dev_err(adev->dev, "FB failed to set tiling flags\n");
> }
>
> -
> ret = amdgpu_bo_pin(abo, domain);
> if (ret) {
> amdgpu_bo_unreserve(abo);
Please drop the removal of these empty lines from this patch.
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
