the previous patch already submitted, so need this patch to fix. thanks. Best Regards, Kevin On 7/24/19 10:34 AM, Quan, Evan wrote: > Better to combine this with previous ptach(drm/amd/powerplay: add callback function of get_thermal_temperature_range) as one. > Since this issue to fix was actually introduced by that patch. > > But if the original patch was already submitted, it's OK to commit this separately. > > Either way, this way is Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > > Regards, > Evan >> -----Original Message----- >> From: Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx> >> Sent: Tuesday, July 23, 2019 8:08 PM >> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx >> Cc: Feng, Kenneth <Kenneth.Feng@xxxxxxx>; Huang, Ray >> <Ray.Huang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>; Wang, >> Kevin(Yang) <Kevin1.Wang@xxxxxxx> >> Subject: [PATCH] drm/amd/powerplay: fix temperature granularity error in >> smu11 >> >> in this patch, >> drm/amd/powerplay: add callback function of >> get_thermal_temperature_range the driver missed temperature granularity >> change on other temperature. >> >> Signed-off-by: Kevin Wang <kevin1.wang@xxxxxxx> >> --- >> drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c >> b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c >> index 745b35a1600d..735802bb07b9 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c >> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c >> @@ -1229,15 +1229,15 @@ static int >> smu_v11_0_start_thermal_control(struct smu_context *smu) >> return ret; >> } >> >> - adev->pm.dpm.thermal.min_temp = range.min; >> - adev->pm.dpm.thermal.max_temp = range.max; >> - adev->pm.dpm.thermal.max_edge_emergency_temp = >> range.edge_emergency_max; >> - adev->pm.dpm.thermal.min_hotspot_temp = range.hotspot_min; >> - adev->pm.dpm.thermal.max_hotspot_crit_temp = >> range.hotspot_crit_max; >> - adev->pm.dpm.thermal.max_hotspot_emergency_temp = >> range.hotspot_emergency_max; >> - adev->pm.dpm.thermal.min_mem_temp = range.mem_min; >> - adev->pm.dpm.thermal.max_mem_crit_temp = >> range.mem_crit_max; >> - adev->pm.dpm.thermal.max_mem_emergency_temp = >> range.mem_emergency_max; >> + adev->pm.dpm.thermal.min_temp = range.min * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_temp = range.max * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_edge_emergency_temp = >> range.edge_emergency_max * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.min_hotspot_temp = range.hotspot_min * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_hotspot_crit_temp = >> range.hotspot_crit_max * SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_hotspot_emergency_temp = >> range.hotspot_emergency_max * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.min_mem_temp = range.mem_min * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_mem_crit_temp = >> range.mem_crit_max * SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> + adev->pm.dpm.thermal.max_mem_emergency_temp = >> range.mem_emergency_max >> +* SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> adev->pm.dpm.thermal.min_temp = range.min * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> adev->pm.dpm.thermal.max_temp = range.max * >> SMU_TEMPERATURE_UNITS_PER_CENTIGRADES; >> >> -- >> 2.22.0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
