No. Hold on. Let me discuss this internally. Regards, Evan > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > Grodzovsky, Andrey > Sent: Wednesday, July 24, 2019 4:01 AM > To: Alex Deucher <alexdeucher@xxxxxxxxx>; amd- > gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx> > Subject: Re: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call > PrepareMp1ForUnload in power_off_asic > > Series is Acked-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx> > > Andrey > > On 7/23/19 1:00 PM, Alex Deucher wrote: > > Needed to make sure the smu is idle when resetting. This may fix > > sporatic failures with GPU reset. > > > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > > --- > > drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > index efb6d3762feb..3d3504411b63 100644 > > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > @@ -2468,6 +2468,11 @@ static int vega12_power_off_asic(struct > pp_hwmgr *hwmgr) > > ); > > data->water_marks_bitmap &= ~(WaterMarksLoaded); > > > > + PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr, > > + PPSMC_MSG_PrepareMp1ForUnload)) == 0, > > + "[PrepareMp1ForUnload] Failed!", > > + return result); > > + > > return result; > > } > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
