Good point. It was following old naming style. But I think we can make some changes to make it more understandable. Let me address this in the V2 version. Regards, Evan > -----Original Message----- > From: Feng, Kenneth <Kenneth.Feng@xxxxxxx> > Sent: Monday, July 22, 2019 12:27 PM > To: Quan, Evan <Evan.Quan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Quan, Evan > <Evan.Quan@xxxxxxx> > Subject: RE: [PATCH 1/5] drm/amd/powerplay: add new sensor type for VCN > powergate status > > I just suggest that we use AMDGPU_PP_SENSOR_VCN_POWER_STATE > instead of AMDGPU_PP_SENSOR_VCN_POWER, since we gets the state of > power on/off, not the real VCN power value. > Reviewed-by: Kenneth Feng <kenneth.feng@xxxxxxx> > > > > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf > Of Evan Quan > Sent: Monday, July 22, 2019 11:15 AM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Quan, Evan > <Evan.Quan@xxxxxxx> > Subject: [PATCH 1/5] drm/amd/powerplay: add new sensor type for VCN > powergate status > > [CAUTION: External Email] > > VCN is widely used in new ASICs and different from tranditional UVD and VCE. > > Change-Id: I35c9db420734029e8f847dcdce23dff1204d70bc > Signed-off-by: Evan Quan <evan.quan@xxxxxxx> > --- > drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h > b/drivers/gpu/drm/amd/include/kgd_pp_interface.h > index 9733bbf9bc72..157e8546855d 100644 > --- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h > +++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h > @@ -123,6 +123,7 @@ enum amd_pp_sensors { > AMDGPU_PP_SENSOR_ENABLED_SMC_FEATURES_MASK, > AMDGPU_PP_SENSOR_MIN_FAN_RPM, > AMDGPU_PP_SENSOR_MAX_FAN_RPM, > + AMDGPU_PP_SENSOR_VCN_POWER, > }; > > enum amd_pp_task { > -- > 2.22.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
