Re: [PATCH 1/3] drm/amd/powerplay: remove mutex lock for smu_handle_task when smu late init

["Quan, Evan" <Evan.Quan@xxxxxxx>]

please hold on the mutex changes of patch1 and patch3. We need an overall thought over the smu mutex machinsim. Let us have some internal discussions first.

---

发件人: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> 代表 Chengming Gui <Jack.Gui@xxxxxxx>
发送时间: Thursday, July 18, 2019 6:02:16 PM
收件人: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
抄送: Gui, Jack <Jack.Gui@xxxxxxx>
主题: [PATCH 1/3] drm/amd/powerplay: remove mutex lock for smu_handle_task when smu late init

 

remove mutex lock when smu late init to call smu_handle_task

Signed-off-by: Chengming Gui <Jack.Gui@xxxxxxx>
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 7d1bd09..122985c 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -569,11 +569,9 @@ static int smu_late_init(void *handle)
 
         if (!smu->pm_enabled)
                 return 0;
-       mutex_lock(&smu->mutex);
         smu_handle_task(&adev->smu,
                         smu->smu_dpm.dpm_level,
                         AMD_PP_TASK_COMPLETE_INIT);
-       mutex_unlock(&smu->mutex);
 
         return 0;
 }
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx