|
RB,
thanks,
Alex
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of StDenis, Tom <Tom.StDenis@xxxxxxx>
Sent: Wednesday, July 17, 2019 8:44 AM To: Koenig, Christian; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface Thanks.
Alex can I grab an R-b please? Cheers, Tom On 2019-07-16 7:30 a.m., Christian König wrote: > Am 16.07.19 um 13:24 schrieb StDenis, Tom: >> The register debugfs interface was using the wrong bitmask for vmid >> selection for GFX_CNTL. >> >> Signed-off-by: Tom St Denis <tom.stdenis@xxxxxxx> > > Acked-by: Christian König <christian.koenig@xxxxxxx> > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c >> index 87b32873046f..59849ed9797d 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c >> @@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool >> read, struct file *f, >> me = (*pos & GENMASK_ULL(33, 24)) >> 24; >> pipe = (*pos & GENMASK_ULL(43, 34)) >> 34; >> queue = (*pos & GENMASK_ULL(53, 44)) >> 44; >> - vmid = (*pos & GENMASK_ULL(48, 45)) >> 54; >> + vmid = (*pos & GENMASK_ULL(58, 54)) >> 54; >> use_ring = 1; >> } else { > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
