Ah! Yeah that was a known issue. Please ignore my response as well :)
Sorry for the noise,
Christian.
Am 16.07.19 um 05:41 schrieb Liu, Monk:
Please ignore this patch, looks 643d146c86c2f1e29cb18db93fbcd2ee43e6959f already addressed the issue.
_____________________________________
Monk Liu|GPU Virtualization Team |AMD
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Monk Liu
Sent: Tuesday, July 16, 2019 11:09 AM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Liu, Monk <Monk.Liu@xxxxxxx>
Subject: [PATCH] SWDEV-196010 Calltrace caught in amdgpu_vm_sdma.c file
don't commit sdma vm job if no updates needed and free the ib
Signed-off-by: Monk Liu <Monk.Liu@xxxxxxx>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index aeba9e6..ff6d37e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1304,9 +1304,15 @@ int amdgpu_vm_update_directories(struct amdgpu_device *adev,
goto error;
}
- r = vm->update_funcs->commit(¶ms, &vm->last_update);
- if (r)
- goto error;
+
+ if (params.ib->length_dw > 0) {
+ r = vm->update_funcs->commit(¶ms, &vm->last_update);
+ if (r)
+ goto error;
+ } else {
+ amdgpu_sa_bo_free(adev, ¶ms.ib->sa_bo, NULL);
+ }
+
return 0;
error:
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx