On Fri, Jul 12, 2019 at 11:05:59PM +0300, Ville Syrjälä wrote: > On Fri, Jul 12, 2019 at 03:48:53PM -0400, Lyude Paul wrote: > > BTW, I just tried these patches on my T450s (using i915) and I'm seeing some > > kernel warnings with them when adding DP aux devices after connecting a new > > MST topology to the system: > > > > [ 367.742571] WARNING: CPU: 2 PID: 442 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xaa/0xb0 [drm] > > Looks like Daniel added that particular WARN in > commit 4f5368b5541a ("drm/kms: Catch mode_object lifetime errors"). And I'm the one who added the max_bpc prop to the mst connectors, which is a per-connector property (ie. a new one gets created for every connecotor). So that could be a problem I suppose. I guess we may need to create just one of these for MST and reuse it for every connector. Could just point at the prop of the corresponding SST connector I suppose... + /* Reuse the prop because blah */ + connector->max_bpc_property = + intel_dp->attached_connector->base.max_bpc_property; drm_connector_attach_max_bpc_property(connector, 6, 12); -- Ville Syrjälä Intel _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx