Series is Reviewed-by: Oak Zeng <Oak.Zeng@xxxxxxx> Regards, Oak -----Original Message----- From: Kuehling, Felix <Felix.Kuehling@xxxxxxx> Sent: Friday, June 21, 2019 3:34 AM To: Zeng, Oak <Oak.Zeng@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH 1/2] drm/amdkfd: Add chained_runlist_idle_disable flag to pm4_mes_runlist Yes. MEC firmware version #425 should have the necessary change. Regards, Felix On 2019-06-20 3:23 p.m., Zeng, Oak wrote: > Hi Felix, > > Does this require a MEC firmware change? > > Regards, > Oak > > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Kuehling, Felix > Sent: Thursday, June 20, 2019 3:22 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Kuehling, Felix <Felix.Kuehling@xxxxxxx> > Subject: [PATCH 1/2] drm/amdkfd: Add chained_runlist_idle_disable flag to pm4_mes_runlist > > New flag to disable an idle runlist optimization that is causing soft hangs with some diffult-to-reproduce customer workloads. This will serve as a workaround until the problem can be reproduced and the root-cause determined. > > Signed-off-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> > --- > drivers/gpu/drm/amd/amdkfd/kfd_pm4_headers_ai.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pm4_headers_ai.h b/drivers/gpu/drm/amd/amdkfd/kfd_pm4_headers_ai.h > index 49ab66b703fa..e3e21404cfa0 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_pm4_headers_ai.h > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pm4_headers_ai.h > @@ -120,7 +120,7 @@ struct pm4_mes_runlist { > uint32_t ib_size:20; > uint32_t chain:1; > uint32_t offload_polling:1; > - uint32_t reserved2:1; > + uint32_t chained_runlist_idle_disable:1; > uint32_t valid:1; > uint32_t process_cnt:4; > uint32_t reserved3:4; > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx