On Fri, 14 Jun 2019 at 19:02, Koenig, Christian <Christian.Koenig@xxxxxxx> wrote: > > Am 14.06.19 um 19:33 schrieb Emil Velikov: > > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > > > Currently the AMDGPU_CTX_PRIORITY_* defines are used in both > > drm_amdgpu_ctx_in::priority and drm_amdgpu_sched_in::priority. > > > > Extend the comment to mention the CAP_SYS_NICE or DRM_MASTER requirement > > is only applicable with the former. > > > > Cc: Bas Nieuwenhuizen <bas@xxxxxxxxxxxxxxxxxxx> > > Cc: Christian König <christian.koenig@xxxxxxx> > > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > --- > > Mildly curious: why didn't one extend ctx_amdgpu_ctx instead of adding > > drm_amdgpu_sched? New flag + _u32 fd at the end (for the former) would > > have been enough (and tweaking the ioctl permission thingy). > > The drm_amdgpu_sched is only allowed for DRM_MASTER. > Fair enough. Is the patch wrong or did it slip through the cracks? I cannot see it in Alex's tree. -Emil _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
