On Wed, Jun 26, 2019 at 12:12 PM Daniel Vetter <daniel@xxxxxxxx> wrote: > > On Wed, Jun 26, 2019 at 11:05:18AM -0400, Kenny Ho wrote: > > drm.memory.stats > > A read-only nested-keyed file which exists on all cgroups. > > Each entry is keyed by the drm device's major:minor. The > > following nested keys are defined. > > > > ====== ============================================= > > system Host/system memory > > Shouldn't that be covered by gem bo stats already? Also, system memory is > definitely something a lot of non-ttm drivers want to be able to track, so > that needs to be separate from ttm. The gem bo stats covers all of these type. I am treat the gem stats as more of the front end and a hard limit and this set of stats as the backing store which can be of various type. How does non-ttm drivers identify various memory types? > > tt Host memory used by the drm device (GTT/GART) > > vram Video RAM used by the drm device > > priv Other drm device, vendor specific memory > > So what's "priv". In general I think we need some way to register the > different kinds of memory, e.g. stuff not in your list: > > - multiple kinds of vram (like numa-style gpus) > - cma (for all those non-ttm drivers that's a big one, it's like system > memory but also totally different) > - any carveouts and stuff privs are vendor specific, which is why I have truncated it. For example, AMD has AMDGPU_PL_GDS, GWS, OA https://elixir.bootlin.com/linux/v5.2-rc6/source/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h#L30 Since we are using keyed file type, we should be able to support vendor specific memory type but I am not sure if this is acceptable to cgroup upstream. This is why I stick to the 3 memory type that is common across all ttm drivers. > I think with all the ttm refactoring going on I think we need to de-ttm > the interface functions here a bit. With Gerd Hoffmans series you can just > use a gem_bo pointer here, so what's left to do is have some extracted > structure for tracking memory types. I think Brian Welty has some ideas > for this, even in patch form. Would be good to keep him on cc at least for > the next version. We'd need to explicitly hand in the ttm_mem_reg (or > whatever the specific thing is going to be). I assume Gerd Hoffman's series you are referring to is this one? https://www.spinics.net/lists/dri-devel/msg215056.html I can certainly keep an eye out for Gerd's refactoring while refactoring other parts of this RFC. I have added Brian and Gerd to the thread for awareness. Regards, Kenny _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
