Re: [PATCH 1/2] drm/amdgpu/powerplay: FEATURE_MASK is 64 bit so use ULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Kevin Wang <kevin1.wang@xxxxxxx>

Best Regards,
Kevin

On 6/25/19 9:58 PM, Alex Deucher wrote:
> ULL is needed for 32 bit arches.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +-
>   drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> index 99b20fed347a..2d43e3dc79f6 100644
> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> @@ -37,7 +37,7 @@
>   
>   #include "asic_reg/mp/mp_11_0_sh_mask.h"
>   
> -#define FEATURE_MASK(feature) (1UL << feature)
> +#define FEATURE_MASK(feature) (1ULL << feature)
>   #define SMC_DPM_FEATURE ( \
>   	FEATURE_MASK(FEATURE_DPM_PREFETCHER_BIT) | \
>   	FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)	 | \
> diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> index 2fc4e2a6fd82..0f14fe14ecd8 100644
> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> @@ -576,7 +576,7 @@ static int vega20_run_btc_afll(struct smu_context *smu)
>   	return smu_send_smc_msg(smu, SMU_MSG_RunAfllBtc);
>   }
>   
> -#define FEATURE_MASK(feature) (1UL << feature)
> +#define FEATURE_MASK(feature) (1ULL << feature)
>   static int
>   vega20_get_allowed_feature_mask(struct smu_context *smu,
>   				  uint32_t *feature_mask, uint32_t num)
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux