please add this message in patch commit. after
Reviewed-by: Kevin Wang <kevin1.wang@xxxxxxx>
Best Regards,
Kevin
On 6/26/19 2:34 PM, Yuan, Xiaojie wrote:
> Current SMU IF version check is too strict, driver with old smu11_driver_if.h sometimes works fine with new SMU firmware. We prefer to see a warning instead a error for debug purposes.
>
> BR,
> Xiaojie
>
> ________________________________________
> From: Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:24:19 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Wang, Kevin(Yang); Yuan, Xiaojie
> Subject: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch
>
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan@xxxxxxx>
> ---
> drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index c3f48fae6f32..339d063e24ff 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct smu_context *smu)
> "smu fw version = 0x%08x (%d.%d.%d)\n",
> smu->smc_if_version, if_version,
> smu_version, smu_major, smu_minor, smu_debug);
> - pr_err("SMU driver if version not matched\n");
> - ret = -EINVAL;
> + pr_warn("SMU driver if version not matched\n");
> }
>
> return ret;
> --
> 2.20.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
