On Mon, Jun 24, 2019 at 06:06:36PM +0000, Russell, Kent wrote: > HI Dan, > > I'll comment inline with [KR] for the most part. > > Most of these come from the fact that "failure" here is not critical. If we can't make the procfs, we just comment about it in dmesg and carry on. If we fail to make the procfs structure here, we just report and carry on. The rest of the kernel can function without it, so failure isn't critical. But I should make this clear in the comments. There is no real error handling required, but we can clarify that with comments. I'll try to address this in a coming patch. > Part of the reason for error handling is just to silence static checker warnings because otherwise everyone has to review it to see if the resource leaks are important. It's easier in the long run to just fix everything no matter how trivial. regards, dan carpenter _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
