On 2019/6/22 14:02, Julia Lawall wrote:
>
>
> On Sat, 22 Jun 2019, Mao Wenan wrote:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>> int ret = 0;
>> ^
>>
>> It is never used since introduction in 9c7c85f7ea1f ("drm/amdgpu: add pmu counters")
>>
>> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
>> index 0e6dba9..0bf4dd9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
>> @@ -246,12 +246,10 @@ static int init_pmu_by_type(struct amdgpu_device *adev,
>> /* init amdgpu_pmu */
>> int amdgpu_pmu_init(struct amdgpu_device *adev)
>> {
>> - int ret = 0;
>> -
>> switch (adev->asic_type) {
>> case CHIP_VEGA20:
>> /* init df */
>> - ret = init_pmu_by_type(adev, df_v3_6_attr_groups,
>> + init_pmu_by_type(adev, df_v3_6_attr_groups,
>> "DF", "amdgpu_df", PERF_TYPE_AMDGPU_DF,
>> DF_V3_6_MAX_COUNTERS);
>
> Maybe it would be better to use ret?
>
> If knowing whether the call has failed is really useless, then maybe the
> return type should be void?
right.
amdgpu_pmu_init() is called by amdgpu_device_init() in drivers/gpu/drm/amd/amdgpu/amdgpu_device.c,
which will use the return value.
amdgpu_device_init()
r = amdgpu_pmu_init(adev);
thanks, I will send v2.
>
> julia
>
>
>>
>> --
>> 2.7.4
>>
>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
