On 2019-06-20 9:49, Alex Deucher wrote: > You never addressed my comments about df init from before. df_init > gets called from hw_init, so you shouldn't create files. Move df init > to being called from soc15 sw_init/fini and probably rename the df > callbacks to sw_init and sw_fini so we know not to add hw state to > those functions. As is now, we'll end up needlessly creating and > destorying files on suspend/resume. Sorry I also missed that comment and the implications, or I would have pointed it out in my code review. Jon's last patch looks mostly good to me and I think it addresses this with minimal fuss. Regards, Felix > > Alex _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
