Dear Alex,
On 06/11/19 16:51, Alex Deucher wrote:
> Fixes SI cards running on amdgpu.
Shouldn’t the caller be updated to check for the error code?
Wouldn’t that be more explicit?
else if (!strcmp(chip_name, "raven") && (amdgpu_pm_load_smu_firmware(adev, &smu_version) == 0)
> Fixes: 1929059893022 ("drm/amd/amdgpu: add RLC firmware to support raven1 refresh")
> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=110883
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index d8828a37e43a..653b2491fec8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -2700,7 +2700,7 @@ void amdgpu_pm_print_power_states(struct amdgpu_device *adev)
>
> int amdgpu_pm_load_smu_firmware(struct amdgpu_device *adev, uint32_t *smu_version)
> {
> - int r = -EINVAL;
> + int r;
>
> if (amdgpu_sriov_vf(adev))
> return 0;
> @@ -2713,7 +2713,7 @@ int amdgpu_pm_load_smu_firmware(struct amdgpu_device *adev, uint32_t *smu_versio
> }
> *smu_version = adev->pm.fw_version;
> }
> - return r;
> + return 0;
> }
>
> int amdgpu_pm_sysfs_init(struct amdgpu_device *adev)
Kind regards,
Paul
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
