Ping...... Best wishes Emily Deng >-----Original Message----- >From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Emily >Deng >Sent: Friday, May 24, 2019 6:33 PM >To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Deng, Emily <Emily.Deng@xxxxxxx> >Subject: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > >[CAUTION: External Email] > >As it will destory clear_state_obj, and also will unpin it in the gfx_v9_0_sw_fini, >so don't need to call csb_vram unpin in gfx_v9_0_hw_fini, or it will have unpin >warning. > >Signed-off-by: Emily Deng <Emily.Deng@xxxxxxx> >--- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 16 ---------------- > 1 file changed, 16 deletions(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >index c763733..231b9e0 100644 >--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >@@ -1154,20 +1154,6 @@ static int gfx_v9_0_csb_vram_pin(struct >amdgpu_device *adev) > return r; > } > >-static void gfx_v9_0_csb_vram_unpin(struct amdgpu_device *adev) -{ >- int r; >- >- if (!adev->gfx.rlc.clear_state_obj) >- return; >- >- r = amdgpu_bo_reserve(adev->gfx.rlc.clear_state_obj, true); >- if (likely(r == 0)) { >- amdgpu_bo_unpin(adev->gfx.rlc.clear_state_obj); >- amdgpu_bo_unreserve(adev->gfx.rlc.clear_state_obj); >- } >-} >- > static void gfx_v9_0_mec_fini(struct amdgpu_device *adev) { > amdgpu_bo_free_kernel(&adev->gfx.mec.hpd_eop_obj, NULL, NULL); >@@ -3385,8 +3371,6 @@ static int gfx_v9_0_hw_fini(void *handle) > gfx_v9_0_cp_enable(adev, false); > adev->gfx.rlc.funcs->stop(adev); > >- gfx_v9_0_csb_vram_unpin(adev); >- > return 0; > } > >-- >2.7.4 > >_______________________________________________ >amd-gfx mailing list >amd-gfx@xxxxxxxxxxxxxxxxxxxxx >https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx