Hi Alex
So sorry for my missing of you patch because the outlook on website didn’t show it.
Your patch seems cleaner and better. Can you help submit it ? Thanks in advance.
Reviewed-by: Yintian Tao<yttao@xxxxxxx>
Can
From: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Sent: Saturday, May 18, 2019 1:07 AM
To: Tao, Yintian <Yintian.Tao@xxxxxxx>; Alex Deucher <alexdeucher@xxxxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Koenig, Christian <Christian.Koenig@xxxxxxx>; Huang, Trigger <Trigger.Huang@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov
Did you see the patch I attached?
From: Tao, Yintian
Sent: Friday, May 17, 2019 10:51 AM
To: Alex Deucher
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Koenig, Christian;
Deucher, Alexander; Huang, Trigger
Subject: 答复: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov
Hi Alex
Many thanks for your review. I will merge these two patches into one and submit again.
Best Regards
Yintian Tao
[CAUTION: External Email]
How about combining these two patches into one? This seems cleaner.
Alex
On Thu, May 16, 2019 at 10:39 PM Tao, Yintian <Yintian.Tao@xxxxxxx> wrote:
>
> Ping...
>
> Hi Christian and Alex
>
>
> Can you help review this? Thanks in advance.
>
>
> Best Regards
> Yintian Tao
>
> -----Original Message-----
> From: Yintian Tao <yttao@xxxxxxx>
> Sent: Thursday, May 16, 2019 8:03 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Tao, Yintian <Yintian.Tao@xxxxxxx>; Huang, Trigger <Trigger.Huang@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov
>
> For Vega10 SR-IOV, vram_width can't be read from ATOM as RAVEN, and DF related registers is not readable, seems hardcord is the only way to set the correct vram_width
>
> Signed-off-by: Trigger Huang <Trigger.Huang@xxxxxxx>
> Signed-off-by: Yintian Tao <yttao@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index c221570..a417763 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -848,6 +848,13 @@ static int gmc_v9_0_mc_init(struct amdgpu_device *adev)
> adev->gmc.vram_width = numchan * chansize;
> }
>
> + /* For Vega10 SR-IOV, vram_width can't be read from ATOM as RAVEN,
> + * and DF related registers is not readable, seems hardcord is the
> + * only way to set the correct vram_width */
> + if (amdgpu_sriov_vf(adev) && (adev->asic_type == CHIP_VEGA10)) {
> + adev->gmc.vram_width = 2048;
> + }
> +
> /* size in MB on si */
> adev->gmc.mc_vram_size =
> adev->nbio_funcs->get_memsize(adev) * 1024ULL * 1024ULL;
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
|
