Re: [PATCH 3/7] drm/dp-mst: Use connector kdev as aux device parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



agh----sorry, but I need to take back my Reviewed-by. Noticed an issue when 
reloading drm and i915. I'll explain it when I respond to patch 2/7 in a
moment

On Thu, 2019-05-16 at 11:17 -0400, sunpeng.li@xxxxxxx wrote:
> From: Leo Li <sunpeng.li@xxxxxxx>
> 
> Placing the MST aux device as a child of the connector gives udev the
> ability to access the connector device's attributes. This will come in
> handy when writing udev rules to create more descriptive symlinks to the
> MST aux devices.
> 
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Lyude Paul <lyude@xxxxxxxxxx>
> Signed-off-by: Leo Li <sunpeng.li@xxxxxxx>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 54da68e..cd2f3c4 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1269,6 +1269,9 @@ static void drm_dp_add_port(struct drm_dp_mst_branch
> *mstb,
>  		}
>  		(*mstb->mgr->cbs->register_connector)(port->connector);
>  
> +		if (port->connector->registration_state ==
> DRM_CONNECTOR_REGISTERED)
> +			port->aux.dev = port->connector->kdev;
> +
>  		drm_dp_aux_register_devnode(&port->aux);
>  	}
>  
-- 
Cheers,
	Lyude Paul

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux