On Wed, 2019-04-24 at 23:52 +0300, Ville Syrjälä wrote: > On Wed, Apr 24, 2019 at 08:40:30PM +0000, Li, Sun peng (Leo) wrote: > > > > > > On 2019-04-24 1:26 p.m., Lyude Paul wrote: > > > Closer, but are we sure we want to use the MST prop path for this? Why > > > not add > > > a sysfs attribute with the corresponding DRM connector name instead > > > since the > > > connector itself will have a path property. That way we can associate > > > aux > > > devices for eDP and DP devices with their corresponding connectors as > > > well > > > > I thought about that as well, but I hit a wall when trying to get the > > SST connector from the aux device. Perhaps there's a simpler way that > > I'm overlooking? > > > > It's easier for MST, since the mst_port can be obtained via container_of > > dp_aux. port->connector would then give what we want. > > > > For SST though, each driver calls drm_aux_register() with an aux struct > > that they've initialized. I'm not sure how I can reliably get the > > drm_connector from that. > > On i915 the aux is a child of the connector, so no extra > attributes/links needed. Maybe other drivers should/could > follow that apporach as well? ooo, good point. Yeah that seems like it would be worth a shot since it'd be a little nicer then just adding more sysfs attributes. But otherwise if that doesn't work, adding a connector parameter to drm_dp_aux_register() should be fine. > -- Cheers, Lyude Paul _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
