|
Please use memset rather than {0}. Apparently some compilers don't like that.
Alex
From: Zhang, Hawking
Sent: Thursday, April 11, 2019 9:24 AM To: Pan, Xinhui; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Deucher, Alexander Subject: RE: [PATCH libdrm] amdgpu: Fix a structure initialization issue Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>
Regards, Hawking -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Pan, Xinhui Sent: 2019年4月11日 19:42 To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx> Subject: [PATCH libdrm] amdgpu: Fix a structure initialization issue struct drmPciBusInfo has been aligned to 6 bytes. So memcmp will access the last byte which is not initialized. That causes the lookup function fails. Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx> --- tests/amdgpu/ras_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/amdgpu/ras_tests.c b/tests/amdgpu/ras_tests.c index 612ad1d7..ebe774fc 100644 --- a/tests/amdgpu/ras_tests.c +++ b/tests/amdgpu/ras_tests.c @@ -190,7 +190,7 @@ static int amdgpu_ras_lookup_id(drmDevicePtr device) { char path[1024]; char str[128]; - drmPciBusInfo info; + drmPciBusInfo info = {0}; int i; int ret; -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
