RE: [PATCH] drm/ttm: fix incrementing the page pointer for huge pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf
> Of Christian K?nig
> Sent: Wednesday, April 10, 2019 5:46 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] drm/ttm: fix incrementing the page pointer for huge pages
> 
> When we increment the counter we need to increment the pointer as well.
> 
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in
> ttm_put_pages()

Acked-by: Huang Rui <ray.huang@xxxxxxx>

> ---
>  drivers/gpu/drm/ttm/ttm_page_alloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> index c74147f0cbe3..627f8dc91d0e 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> @@ -733,7 +733,7 @@ static void ttm_put_pages(struct page **pages,
> unsigned npages, int flags,
>  			if (!(flags & TTM_PAGE_FLAG_DMA32) &&
>  			    (npages - i) >= HPAGE_PMD_NR) {
>  				for (j = 1; j < HPAGE_PMD_NR; ++j)
> -					if (p++ != pages[i + j])
> +					if (++p != pages[i + j])
>  					    break;
> 
>  				if (j == HPAGE_PMD_NR)
> @@ -768,7 +768,7 @@ static void ttm_put_pages(struct page **pages,
> unsigned npages, int flags,
>  				break;
> 
>  			for (j = 1; j < HPAGE_PMD_NR; ++j)
> -				if (p++ != pages[i + j])
> +				if (++p != pages[i + j])
>  				    break;
> 
>  			if (j != HPAGE_PMD_NR)
> --
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux