Re: [PATCH] drm/amd/display: Initialize stream_update with memset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/19 9:49 AM, Paul Menzel wrote:
> Dear Nicholas,
> 
> 
> On 03/22/19 14:15, Nicholas Kazlauskas wrote:
>> The brace initialization used here generates errors on some
>> compilers. Use memset to make this more portable.
> 
> Could you please specify the problematic compiler/toolchain in
> the commit message?
> 
> […]
> 
> 
> Kind regards,
> 
> Paul
> 

I actually meant warning in this case - since I usually build amdgpu 
with warnings as errors. In this case it was an older version of GCC 
that generated the warning (4.9). Though I think clang does as well, I 
forgot to make this patch after I saw the email from Nils Wallménius a 
while back. There were similar issues in a few other places:

https://lists.freedesktop.org/archives/amd-gfx/2019-February/031116.html

I'll update the commit message and post a v2, thanks!

Nicholas Kazlauskas
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux