Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v5/20190313-080623
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

All warnings (new ones prefixed by >>):

>> drivers/dma-buf/dma-fence-chain.c:34:40: sparse: warning: incorrect type in argument 1 (different address spaces)
   drivers/dma-buf/dma-fence-chain.c:34:40: sparse:    expected struct dma_fence [noderef] <asn:4> **fencep
   drivers/dma-buf/dma-fence-chain.c:34:40: sparse:    got struct dma_fence **

sparse warnings: (new ones prefixed by >>)

   drivers/dma-buf/dma-fence-chain.c:34:40: sparse: warning: incorrect type in argument 1 (different address spaces)
>> drivers/dma-buf/dma-fence-chain.c:34:40: sparse:    expected struct dma_fence [noderef] <asn:4> **fencep
>> drivers/dma-buf/dma-fence-chain.c:34:40: sparse:    got struct dma_fence **

vim +34 drivers/dma-buf/dma-fence-chain.c

    21	
    22	/**
    23	 * dma_fence_chain_get_prev - use RCU to get a reference to the previous fence
    24	 * @chain: chain node to get the previous node from
    25	 *
    26	 * Use dma_fence_get_rcu_safe to get a reference to the previous fence of the
    27	 * chain node.
    28	 */
    29	static struct dma_fence *dma_fence_chain_get_prev(struct dma_fence_chain *chain)
    30	{
    31		struct dma_fence *prev;
    32	
    33		rcu_read_lock();
  > 34		prev = dma_fence_get_rcu_safe(&chain->prev);
    35		rcu_read_unlock();
    36		return prev;
    37	}
    38	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux