RE: [PATCH] drm/amdgpu: Fix ras debugfs data parse

["Xu, Feifei" <Feifei.Xu@xxxxxxx>]

Reviewed-by: Feifei Xu <Feifei.Xu@xxxxxxx>

 

 

From: Pan, Xinhui <Xinhui.Pan@xxxxxxx>
Sent: Monday, March 11, 2019 6:26 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Xu, Feifei <Feifei.Xu@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Fix ras debugfs data parse

 

Unzero char is accepted by sscanf, so when data is structure but

unexpectedly return error invalid;

 

Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx>

---

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

index 74a65a61fd23..a5336d16aa4d 100644

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

@@ -241,7 +241,7 @@ static int amdgpu_ras_debugfs_ctrl_parse_data(struct file *f,

                            op = 1;

             else if (sscanf(str, "inject %32s %8s", block_name, err) == 2)

                            op = 2;

-             else if (sscanf(str, "%32s", block_name) == 1)

+            else if (str[0] && str[1] && str[2] && str[3])

                            /* ascii string, but commands are not matched. */

                            return -EINVAL;

 

--

2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx