RE: [PATCH] drm/amdgpu: Fix NULL pointer when ta is missing

["Zhang, Hawking" <Hawking.Zhang@xxxxxxx>]

Would it make sense to check ta fw availability before call into psp_ras_initialize? In such way, we can avoid unnecessary device error kernel message that complains ras init failure on the ASICs that actually don’t have RAS support. Accordingly, you need similar logic before call into psp_ras_terminate in hw_fini phase.

 

Regards,
Hawking

From: Pan, Xinhui <Xinhui.Pan@xxxxxxx>
Sent: 2019年3月11日 12:23
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Gao, Likun <Likun.Gao@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Fix NULL pointer when ta is missing

 

Ta is optional, so check if ta firmware is loaded or not.

 

Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx>

---

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++

1 file changed, 3 insertions(+)

 

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

index 7e3e1d588d74..0bd9df9fd289 100644

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

@@ -656,6 +656,9 @@ static int psp_ras_initialize(struct psp_context *psp)

{

             int ret;

 

+            if (!psp->adev->psp.ta_fw)

+                           return -ENOENT;

+

             if (!psp->ras.ras_initialized) {

                            ret = psp_ras_init_shared_buf(psp);

                            if (ret)

--

2.17.1

 

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx