On 2019-03-06 4:41 p.m., Yang, Philip wrote: > If using old kernel config file, CONFIG_ZONE_DEVICE is not selected, > so CONFIG_HMM and CONFIG_HMM_MIRROR is not enabled, the current driver > error message "Failed to register MMU notifier" is not clear. Inform > user with more descriptive message on how to fix the missing kernel > config option. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109808 > > Change-Id: Idfebaeababa4c37c1ef093c2b91a26910a167585 > Signed-off-by: Philip Yang <Philip.Yang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h > index 4803e216e174..ee5541b49604 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h > @@ -53,6 +53,8 @@ static inline struct amdgpu_mn *amdgpu_mn_get(struct amdgpu_device *adev, > } > static inline int amdgpu_mn_register(struct amdgpu_bo *bo, unsigned long addr) > { > + DRM_WARN_ONCE("HMM_MIRROR kernel config option is not enabled, " > + "add CONFIG_ZONE_DEVICE=y in config file to fix this\n"); With the second line indentation fixed to properly line up with the opening parenthesis, Reviewed-by: Michel Dänzer <michel.daenzer@xxxxxxx> -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
