On 2019-03-06 10:04 a.m., Christian König wrote: > Am 06.03.19 um 16:02 schrieb Yang, Philip: >> If using old kernel config file, CONFIG_ZONE_DEVICE is not selected, >> so CONFIG_HMM and CONFIG_HMM_MIRROR is not enabled, the current driver >> error message "Failed to register MMU notifier" is not clear. Inform >> user with more descriptive message on how to fix the missing kernel >> config option. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109808 >> >> Change-Id: Idfebaeababa4c37c1ef093c2b91a26910a167585 >> Signed-off-by: Philip Yang <Philip.Yang@xxxxxxx> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h >> index 4803e216e174..a5fd73fc24bf 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h >> @@ -53,6 +53,8 @@ static inline struct amdgpu_mn *amdgpu_mn_get(struct >> amdgpu_device *adev, >> } >> static inline int amdgpu_mn_register(struct amdgpu_bo *bo, unsigned >> long addr) >> { >> + DRM_WARN_ONCE("HMM_MIRROR kernel config option is not enabled\n"); >> + DRM_WARN_ONCE("add CONFIG_ZONE_DEVICE=y in config file to fix >> this\n"); > > One message please, apart from that looks good to me. > > Christian. > Do you mean use multiple line string with one DRM_WARN_ONCE call? That will get checkpatch warning "WARNING: quoted string split across lines". Can I just ignore that checkpatch warning? Philip >> return -ENODEV; >> } >> static inline void amdgpu_mn_unregister(struct amdgpu_bo *bo) {} > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
