On Mon, Feb 4, 2019 at 11:09 AM Koenig, Christian <Christian.Koenig@xxxxxxx> wrote: > > Am 04.02.19 um 16:55 schrieb Marek Olšák: > > On Mon, Feb 4, 2019 at 7:42 AM Christian König <ckoenig.leichtzumerken@xxxxxxxxx> wrote: >> >> At least from coding style, backward compatibility etc.. this looks sane to me, so feel free to add an Acked-by. >> >> But I absolutely can't judge if that is correct from the hardware point of view or not. > > > Our GDS docs say that writing the register resets the wave counter. > >> >> >> And I think that somebody else looking at this is mandatory for it to be committed. > > > There won't be anybody else. Nobody here really understands GDS, nobody here really cares about GDS, and hw guys weren't helpful with the hangs. If I didn't discover this by luck, GDS OA would be unusable on Linux. > > > Great, as long as Alex is ok with this feel free to go ahead. Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> > > Christian. > > > Marek > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
