Yes, thanks. I have modified the typo mistake of "response". BR, Aaron Liu > -----Original Message----- > From: Paul Menzel <pmenzel+amd-gfx@xxxxxxxxxxxxx> > Sent: Tuesday, January 15, 2019 7:07 PM > To: Liu, Aaron <Aaron.Liu@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [[PATCH v2]drm/amdgpu/psp: ignore psp reponse status] > drm/amdgpu/psp: ignore psp reponse status > > Dear Aaron, > > > On 01/15/19 07:30, Liu, Aaron wrote: > > > The psp code only support ucode loading at the beginning, but forgot > > to remove the checking when more and more PSP command get into PSP. > > I didn’t know that, and missed that your patch is not only about > microcode loading. > > > So some old PSP FW maybe have problem but PSP driver didn’t find it > > out. If reverting the patch, we also can’t find out wrong PSP FW and > > have big problem when support new PSP command. > > Understood. > > > The temporary solution is: do not return error if response is invalid > > but add warning message to notify, it will not block old FW and get > > attention if new PSP FW have some issue. > There is still a small typo in *response* in the summary. > > > Kind regards, > > Paul _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
