On 2018-12-18 8:09 p.m., Mario Kleiner wrote: > On Tue, Dec 18, 2018 at 3:42 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: >> >> Good catch, thanks! Pushed with >> >> Fixes: 740f0850f1e4 "Store FB for each CRTC in drmmode_flipdata_rec" >> Reviewed-by: Michel Dänzer <michel.daenzer@xxxxxxx> >> >> >> Do you want to make an xf86-video-amdgpu merge request as well? If not, >> I can take care of porting the fix. If you do it, please enable the >> "Allow commits from members who can merge to the target branch" checkbox >> for the MR. >> > > Hi Michel, > > thanks for the fast review! If you could port it to amdgpu, that would be good. > I first have to learn the new gitlab workflow and find out how those > merge requests work. It's easy: Click the "Fork" button on https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu to create your personal repository. Push the change(s) to be part of the merge request (MR) to a new branch in your personal repository. The terminal output of git push should contain an URL for creating a merge request for the new branch. Make sure the "Allow commits from members who can merge to the target branch" box is checked. I usually check the "Remove source branch when merge request is accepted" box as well. Once the MR is created, make sure the CI pipeline passes, or investigate and fix any failures. The MR page has a button for rebasing the branch if needed. If you need to make any other modifications to the commits, just (force-)push to the same branch again and reload the MR page. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
