Hi Xiangliang, Could you add more comment on the session_id in the commit message? Like using the session_id to distinguish each VF v.s. PF etc. With that added,Reviewed-by: Feifei Xu<Feifei.Xu@xxxxxxx> Thanks Feifei -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Xiangliang Yu Sent: Thursday, December 13, 2018 3:41 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Yu, Xiangliang <Xiangliang.Yu@xxxxxxx> Subject: [PATCH 1/2] drm/amdgpu/psp: Fix to get wrong xgmi session id xGMI session id should get from response buffer, correct it. Signed-off-by: Xiangliang Yu <Xiangliang.Yu@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 8fab0d6..2f126ea7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c @@ -147,6 +147,9 @@ psp_cmd_submit_buf(struct psp_context *psp, return -EINVAL; } + /* get xGMI session id from response buffer */ + cmd->resp.session_id = psp->cmd_buf_mem->resp.session_id; + if (ucode) { ucode->tmr_mc_addr_lo = psp->cmd_buf_mem->resp.fw_addr_lo; ucode->tmr_mc_addr_hi = psp->cmd_buf_mem->resp.fw_addr_hi; -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx