KFD only works with x86_64. So we still need the switch to disable KFD on i386 and other architectures that are not (yet) supported. I'll look into a fix as soon as I can. Thanks for the heads up. Regards, Felix On 2018-12-10 11:25 a.m., Bridgman, John wrote: > > Do we still need the HSA_AMD option ? > > > Seems to me that KFD stopped being "something we only sometimes > include" a long time ago. > > > Thanks, > John > > > ------------------------------------------------------------------------ > *From:* amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of > StDenis, Tom <Tom.StDenis@xxxxxxx> > *Sent:* December 10, 2018 10:02 AM > *To:* Kuehling, Felix > *Cc:* Huang, JinHuiEric; Deucher, Alexander; amd-gfx mailing list > *Subject:* amdkfd build regression if HSA_AMD is disabled > > Hi All, > > The commit: > > commit 62f65d3cb34a8300bf1e07fc478e03c3c02634d4 > Refs: v4.20-rc3-524-g62f65d3cb34a > Author: Felix Kuehling <Felix.Kuehling@xxxxxxx> > AuthorDate: Mon Nov 19 20:05:54 2018 -0500 > Commit: Felix Kuehling <Felix.Kuehling@xxxxxxx> > CommitDate: Fri Dec 7 17:17:11 2018 -0500 > > drm/amdgpu: Add KFD VRAM limit checking > > We don't want KFD processes evicting each other over VRAM usage. > Therefore prevent overcommitting VRAM among KFD applications with > a per-GPU limit. Also leave enough room for page tables on top > of the application memory usage. > > Signed-off-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> > Reviewed-by: Eric Huang <JinHuiEric.Huang@xxxxxxx> > Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> > > Breaks the build if HSA_AMD is not enabled: > > scripts/kconfig/conf --syncconfig Kconfig > DESCEND objtool > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > Building modules, stage 2. > MODPOST 63 modules > Kernel: arch/x86/boot/bzImage is ready (#58) > ERROR: "amdgpu_amdkfd_unreserve_memory_limit" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > make: *** [Makefile:1271: modules] Error 2 > > This is because the function being used is not included in the build > (the previous function called was part of amdgpu_amdkfd.c which is > unconditionally built). > > Cheers, > Tom > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
