RE: build broken on drm-next

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jack already have a patch to fix this issue. 

Thanks,
Ray

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf
> Of StDenis, Tom
> Sent: Monday, December 10, 2018 8:07 PM
> To: Zhou, Tiecheng <Tiecheng.Zhou@xxxxxxx>; amd-gfx mailing list <amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: build broken on drm-next
> 
> Hi,
> 
> This commit
> 
> commit e421c656beefa1044f65cf50d7a7455df60cd703
> 
> Refs: v4.20-rc3-530-ge421c656beef
> 
> Author:     Tiecheng Zhou <Tiecheng.Zhou@xxxxxxx>
> 
> AuthorDate: Fri Dec 7 09:11:35 2018 +0800
> 
> Commit:     Tiecheng Zhou <Tiecheng.Zhou@xxxxxxx>
> 
> CommitDate: Mon Dec 10 11:14:27 2018 +0800
> 
> 
>      drm/amdgpu: bypass RLC init under sriov for Tonga
> 
>      RLC will go wrong in soft_reset under sriov
> 
>      Workaroound: only need to init RLC csb, and skip RLC stop, reset, start
>          this is because host-driver has already done full initialization on RLC
> 
>      Signed-off-by: Tiecehng Zhou <Tiecheng.Zhou@xxxxxxx>
> 
>      Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> 
> 
> Causes a build error on amd-staging-drm-next:
> 
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
> ‘gfx_v8_0_rlc_resume’:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4071:6: error: implicit declaration
> of function ‘amdgpu_sriov’; did you mean ‘amdgpu_sriov_vf’?
> [-Werror=implicit-function-declaration]
>    if (amdgpu_sriov(adev)) {
>        ^~~~~~~~~~~~
>        amdgpu_sriov_vf
>    CC [M]  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.o
>    CC [M]  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.o
>    CC [M]  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.o
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:293:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [scripts/Makefile.build:518: drivers/gpu/drm/amd/amdgpu]
> Error 2
> make[2]: *** [scripts/Makefile.build:518: drivers/gpu/drm] Error 2
> make[1]: *** [scripts/Makefile.build:518: drivers/gpu] Error 2
> make: *** [Makefile:1060: drivers] Error 2
> 
> 
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--- Begin Message ---
Signed-off-by: Chengming Gui <Jack.Gui@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index a9c853a..08f443f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -4068,7 +4068,7 @@ static void gfx_v8_0_rlc_start(struct amdgpu_device *adev)

 static int gfx_v8_0_rlc_resume(struct amdgpu_device *adev)
 {
-       if (amdgpu_sriov(adev)) {
+       if (amdgpu_sriov_vf(adev)) {
                gfx_v8_0_init_csb(adev);
                return 0;
        }
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--- End Message ---
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux