Does this solve a problem? If so, you could write that in the commit message. Regards //Ernst Den tors 22 nov. 2018 kl 19:22 skrev Liu, Shaoyun <Shaoyun.Liu@xxxxxxx>: > > Driver shouldn't try to access any GFX registers until RLC is idle. > During the test, it took 12 seconds for RLC to clear the BUSY bit > in RLC_GPM_STAT register which is un-acceptable for driver. > As per RLC engineer, it would take RLC Ucode less than 10,000 GFXCLK > cycles to finish its critical section. In a lowest 300M enginer clock > setting(default from vbios), 50 us delay is enough. > > Change-Id: If074fbeeecad3f63cf5f5ab232472d0fe46082a6 > Signed-off-by: shaoyunl <shaoyun.liu@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index e409fbf..9686fcc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -2326,12 +2326,13 @@ static void gfx_v9_0_rlc_start(struct amdgpu_device *adev) > #endif > > WREG32_FIELD15(GC, 0, RLC_CNTL, RLC_ENABLE_F32, 1); > + udelay(50); > > /* carrizo do enable cp interrupt after cp inited */ > - if (!(adev->flags & AMD_IS_APU)) > + if (!(adev->flags & AMD_IS_APU)) { > gfx_v9_0_enable_gui_idle_interrupt(adev, true); > - > - udelay(50); > + udelay(50); > + } > > #ifdef AMDGPU_RLC_DEBUG_RETRY > /* RLC_GPM_GENERAL_6 : RLC Ucode version */ > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx