Re: [PATCH] drm/amd: add the checking to avoid NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 22.11.18 um 03:36 schrieb Sharma, Deepak:
when returned fence is not valid mostly due to userspace ignored
previous error causes NULL pointer dereference

NAK, when the fence is NULL then this means it is already signaled and no longer in the container.

In other words this is a normal case and the following functions need to be able to handle that.

Christian.


Signed-off-by: Deepak Sharma <Deepak.Sharma@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 024dfbd87f11..c85bb313e6df 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -1420,6 +1420,8 @@ int amdgpu_cs_fence_to_handle_ioctl(struct drm_device *dev, void *data,
  	fence = amdgpu_cs_get_fence(adev, filp, &info->in.fence);
  	if (IS_ERR(fence))
  		return PTR_ERR(fence);
+	if (!fence)
+		return -EINVAL;
switch (info->in.what) {
  	case AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ:

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux