Re: [PATCH] drm/amdgpu: Remove dead static variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 20.11.18 um 11:48 schrieb Emil Velikov:
> On Mon, 19 Nov 2018 at 11:19, Christian König
> <ckoenig.leichtzumerken@xxxxxxxxx> wrote:
>> Am 19.11.18 um 12:07 schrieb Rex Zhu:
>>> The static struct drm_driver *driver was
>>> not used because drm_pci_init was deprecated
>>>
>>> Signed-off-by: Rex Zhu <Rex.Zhu@xxxxxxx>
>> Reviewed-by: Christian König <christian.koenig@xxxxxxx>
>>
>> Can you of hand see what "pdriver" is used for? That looks suspicious
>> like something deprecated as well.
>>
> Seeming copy/paste from the radeon driver. The latter used to support
> UMS and KMS at some point in the past.

Yeah, thought so. Rex cam up with a V2 where both variables are removed.

Thanks,
Christian.

>
> HTH
> -Emil

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux