On Fri, Oct 19, 2018 at 12:45 PM zhoucm1 <zhoucm1@xxxxxxx> wrote: > > > [snip] > >>> Went boom: > >>> > >>> https://bugs.freedesktop.org/show_bug.cgi?id=108490 > >>> > >>> Can we revert pls? > >> Sorry for bug, please. > > In fact, the bug is already caught and fixed, just the fix part isn't > > in patch#1, but in patch#2: > > > > Have you reverted? If not, I can send that fix in one minute. > > > > > > Regards, > > David Zhou > >>> > >>> Also, can we please have igts for this stuff so that intel-gfx-ci could > >>> test this properly before it's all fireworks? > Hi Daniel V, > > Could you point me which problem I encounter when I run syncobj_wait of igt? > > jenkins@jenkins-MS-7984:~/freedesktop/igt-gpu-tools/tests$ ./syncobj_wait > IGT-Version: 1.23-g94ebd21 (x86_64) (Linux: 4.19.0-rc5-custom+ x86_64) > Test requirement not met in function igt_require_sw_sync, file > sw_sync.c:240: > Test requirement: kernel_has_sw_sync() > Last errno: 2, No such file or directory The test isn't even run because one of it's requirements isn't met. In this case here you don't have the SW_SYNC stuff enabled, which is used to for testing. CONFIG_SW_SYNC in the kernel. You could do a quick igt patch to change the igt_require() to an igt_require_f() with something like "You need to enable CONFIG_SW_SYNC in your kernel build" as the help text. -Daniel > > Thanks, > David Zhou > >> Seems we cannot avoid igt now and vulkan CTS isn't enough, I will > >> find some time next week to lean IGT, looks v10 is need. > >> > >> Regards, > >> David Zhou > >>> > >>> Thanks, Daniel > >>> > >>>>> The rest in the series looks good to me as well, > >>>> Can I get your RB on them first? > >>>> > >>>>> but I certainly want the radv/anv developers to take a look as > >>>>> well as > >>>>> Daniel suggested. > >>>> Ping @Dave/Bas/Jason or other radv/anv developers, Could anyone of > >>>> you take > >>>> a look the rest of series for u/k interface? So that we can move to > >>>> next > >>>> step for libdrm patches? > >>>> > >>>> Thanks, > >>>> David > >>>>> Christian. > >>>>> > >>>>>> Thanks, > >>>>>> David Zhou > >>>>>> > >>>>>>> -Daniel > >>>>>> _______________________________________________ > >>>>>> amd-gfx mailing list > >>>>>> amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx