Re: [PATCH] drm/amdgpu/display: dm/amdgpu: make dp phy debugfs for eDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2018-10-12 10:50 a.m., sunpeng.li@xxxxxxx wrote:
> From: hersen wu <hersenxs.wu@xxxxxxx>
> 
> [WHY] dp debugfs file does not exist for eDP under
>       /sys/kernel/debug/dri/0/eDP-1. the root is phy debugfs
>       is created for dp connector only.
> [HOW] for eDP connector, create phy debugfs too.
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@xxxxxxx>
> Reviewed-by: David Francis <David.Francis@xxxxxxx>
> Acked-by: Leo Li <sunpeng.li@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 0ef4a40..76a9c95 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -705,7 +705,9 @@ int connector_debugfs_init(struct amdgpu_dm_connector *connector)
>  	int i;
>  	struct dentry *ent, *dir = connector->base.debugfs_entry;
>  
> -	if (connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
> +	if (connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> +			connector->base.connector_type ==
> +					DRM_MODE_CONNECTOR_eDP) {

Indenting looks funky. Would be nice to get that cleaned up before merge.

Anyways, beside the bikeshedding this is
Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Harry

>  		for (i = 0; i < ARRAY_SIZE(dp_debugfs_entries); i++) {
>  			ent = debugfs_create_file(dp_debugfs_entries[i].name,
>  						  0644,
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux