|
I think it's useful to keep around for bringup and early in the asic lifecycle.
Alex From: Zhu, Rex
Sent: Tuesday, October 9, 2018 11:39:49 PM To: Deucher, Alexander; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg Ok.
BTW, Maybe we can remove the module parameter
amdgpu_fw_load_type suppor . It is only used for bring up/debug.
Best Regards Rex
From: Deucher, Alexander
Sent: Wednesday, October 10, 2018 3:31 AM To: Zhu, Rex; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg Maybe just drop the warning altogether? We only support SMU loading on VI at this point. Otherwise, we'll need to update this if we ever add a new fw loading type.
Alex From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Rex Zhu <Rex.Zhu@xxxxxxx>
Sent: Tuesday, October 9, 2018 11:36 AM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Zhu, Rex Subject: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg Fix the warning message:
"-1 is not supported on VI" the -1 is the default fw load type, mean auto. v2: fix typo Signed-off-by: Rex Zhu <Rex.Zhu@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c index 971549f..01d794d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c @@ -297,7 +297,7 @@ enum amdgpu_firmware_load_type case CHIP_POLARIS11: case CHIP_POLARIS12: case CHIP_VEGAM: - if (load_type != AMDGPU_FW_LOAD_SMU) + if (load_type == AMDGPU_FW_LOAD_DIRECT || load_type == AMDGPU_FW_LOAD_PSP) pr_warning("%d is not supported on VI\n", load_type); return AMDGPU_FW_LOAD_SMU; case CHIP_VEGA10: -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
