> -----Original Message----- > From: Michel Dänzer <michel@xxxxxxxxxxx> > Sent: Tuesday, October 9, 2018 9:19 PM > To: Zhu, Rex <Rex.Zhu@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 4/5] drm/amdgpu: Fix unnecessary warning in dmesg > > On 2018-10-09 2:43 p.m., Rex Zhu wrote: > > Fix the warning message: > > "-1 is not supported on VI" > > the -1 is the default fw load type, mean auto. > > > > Signed-off-by: Rex Zhu <Rex.Zhu@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > > index f2604ac..e5b13b2 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > > @@ -297,7 +297,7 @@ enum amdgpu_firmware_load_type > > case CHIP_POLARIS11: > > case CHIP_POLARIS12: > > case CHIP_VEGAM: > > - if (load_type != AMDGPU_FW_LOAD_SMU) > > + if (load_type != AMDGPU_FW_LOAD_DIRECT || load_type == > AMDGPU_FW_LOAD_PSP) > > AMDGPU_FW_LOAD_PSP == 2 != AMDGPU_FW_LOAD_DIRECT == 0 > > I suspect you meant something else here. Yes, it should be - if (load_type != AMDGPU_FW_LOAD_SMU) + if (load_type == AMDGPU_FW_LOAD_DIRECT || load_type == AMDGPU_FW_LOAD_PSP) Typo when split the patches. Thanks for pointing it out. Best Regards Rex > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
